Fix crash caused by negative waveform.#461
Merged
Merged
Conversation
Member
|
Setting a negative float to an unsigned int is undefined behavior in C++. It is better that we find out why negative signals are produced and fix the problem there and/or explicitly set a negative signal to zero perhaps with a single warning log message. |
Author
|
OK, I modified the merge branch to test for negative values. |
Member
|
If I understand, the fix to larwirecell will hide this problem, but this protection is still good so I'll merge. Here's the larwirecell PR for future reference LArSoft/larwirecell#65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.